Fix MSB before LSB #101
Merged
Fix MSB before LSB #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ping @Fabien-Chouteau :) |
|
@pat-rogers is the one to ping here ^^ Pat can you have a look? |
pat-rogers
approved these changes
Oct 30, 2023
|
Pinging so that it gets merged (hopefully) :) |
pat-rogers
approved these changes
Nov 9, 2023
|
It looks good to me. |
|
Oh, I have signed it several times already. I thought that once was enough... Is it setup to ask for the CLA for every PR? I will sign it once again nonetheless... |
|
On 09-Nov-23 2:18 PM, Fernando Oleo Blanco wrote:
Oh, I have signed it several times already. I thought that once was
enough... Is it setup to ask for the CLA for every PR?
I believe it is set up for each project, but I didn't set it up so
cannot speak authoritatively on it.
Definitely not once per PR, though.
I will sign it
once again nonetheless...
Thanks!
Pat
|
|
@pat-rogers ping? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #88
I need this because Litex generates SVD files declaring MSB before LSB. Just a few lines had to be changed, however, due to a new declare affecting the whole loop, it seems much larger than needed.
PLEASE, test this with other SVDs. Nothing should have broken, but still. I cannot test the changes as I don't really have many SVDs at hand.
Pinging: @Fabien-Chouteau
Best regards,
Fer