Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement vec<> class #415

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Reimplement vec<> class #415

merged 3 commits into from
Dec 17, 2020

Conversation

illuhad
Copy link
Collaborator

@illuhad illuhad commented Dec 14, 2020

Reimplement and simplify vec class to not rely on CUDA/HIP vector types which currently don't yield any performance benefits with clang anyway (note that, if there are performance benefits in the future we could still always specialize the vec_storage backend to use them for cases where it makes sense).

Key stats of this change:

  • -3000 lines of code (!)
  • +50% readability
  • +100% maintainability
  • +20% C++17 (old implementation was based on C++14 and hence did not use fold expressions)
  • +/- 0% performance (expected)
  • +10% spec conformance, e.g. alignments.
  • +5% SYCL 2020 (implements SYCL 2020 additions to the vec interface)

@illuhad
Copy link
Collaborator Author

illuhad commented Dec 15, 2020

@hipSYCL-ci-bot test this please, my favorite bot!

@illuhad illuhad merged commit cf0d49c into develop Dec 17, 2020
@illuhad illuhad deleted the feature/vec-rewrite branch December 17, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant