Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'Fit to Screen' option #45

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Conversation

Metacor
Copy link
Contributor

@Metacor Metacor commented Oct 21, 2022

added the 'isLocalFile' check mentioned in #44 (hides broken buttons)
fix #33 - added 'Fit to Screen' +('Toolbar' button | 'Shortcuts' hotkey | 'Settings' toggle)

I also tried adding a 'Default View' selector, to choose between "current/1:1/fit", but I was unable to get it to work.

I'd recommend releasing v1.0.6 with this merge
'Fit to Screen' is the final Feature that I initially wanted, so this will likely be my last Pull Request for awhile.

@Metacor
Copy link
Contributor Author

Metacor commented Nov 17, 2022

Is there any reason this hasn't been accepted?

@Ademking
Copy link
Owner

@Metacor Sorry for the late reply. I was so busy this month..
Thank you again for your contribution! Things don’t get better without your help! ❤️

@Ademking Ademking merged commit e3a083e into Ademking:master Nov 21, 2022
@Metacor Metacor deleted the feature/fit-to-screen branch November 22, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Maximise image button
2 participants