Change .kotlin_module generated name #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid taking the name of the current folder to generate the kotlin_module generated into the .aar/META-INF. In practice, rename "META-INF/library_release.kotlin_module" to "META-INF/barista.kotlin_module". This avoid Barista consumers to exclude this file if another library generated the same one. See: https://stackoverflow.com/q/44509608
|
Seems legit to me 😅 Thanks for the PR! Going to try it in localhost because honesty, I (and I think we) never faced the issue 👯 |
Sloy
approved these changes
May 20, 2020
There was a problem hiding this comment.
Hi @crgarridos! 👋
We didn't encounter this either, but your fix sounds right.
Thank you!
|
Oh, just read you @Sloy, didn't refresh the page. So... merge at will then 👍 Thanks @crgarridos for this lovely contribution! |
alorma
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I confronted the following error while building with barista and an internal company's library.
And found out that barista is taking this name too:
I've already fixed on our side but think this could be useful for other barista users.
This PR has as purpose avoid taking the name of the current folder to generate the
kotlin_module generated into the .aar/META-INF.
In practice, rename "META-INF/library_release.kotlin_module" to
"META-INF/barista.kotlin_module".
This avoid Barista consumers to exclude this file if another library
generated the same one.
See: https://stackoverflow.com/q/4450960