Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.aglintrc.json file json schema for autocompletion #210

Open
royhadad opened this issue Jun 24, 2024 · 2 comments · May be fixed by #211
Open

.aglintrc.json file json schema for autocompletion #210

royhadad opened this issue Jun 24, 2024 · 2 comments · May be fixed by #211
Assignees

Comments

@royhadad
Copy link

I tried to configure the .aglintrc.json file, and noticed there is no json schema for it (which adds autocomplete in common editors like VSCode/InteliJ.

We can see an example from the Datree project (which I used to be a maintainer of):
https://github.com/datreeio/datree/blob/0c3b63e6ce9688cdb5ad3bf06768875664cf15be/pkg/validatePoliciesYaml/policiesSchema.json

the schema can be pushed into schema store for auto completion.

I just wanna validate 2 things before I code it and open a PR:

  1. Would we be happy to add something like that to the project?
  2. Anything I should be aware of? I noticed we have some code specifying the aglintrc file here
@scripthunter7
Copy link
Member

Hi @royhadad,

I think this is a good idea, thanks if you do it :) The structure of the config file is documented in the following link:

https://github.com/AdguardTeam/AGLint?tab=readme-ov-file#configuration-file-structure

@scripthunter7
Copy link
Member

I think JSON schemas also can be added to our extension: AdguardTeam/VscodeAdblockSyntax#136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants