Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/dhcp/find_active_dhcp - never finishes it's work (may be specific to a snap version) #2301

Closed
ameshkov opened this issue Nov 12, 2020 · 3 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

There's is no timeout (anymore?) for this method.

@TooYoungTooSimp
Copy link

TooYoungTooSimp commented Nov 12, 2020

I'm using agh on plain archlinux without snap, and after I reset dhcp settings and when try to reconfigure it. This problem happens. So this should not be a snap related issue?

@ameshkov
Copy link
Member Author

Yeah, it seems global. The solution for now would be tp enable DHCP via AdGuardHome.yaml

@ainar-g
Copy link
Contributor

ainar-g commented Nov 13, 2020

As far as I can tell, there is a timeout for request reading here, but not for writing and not for the DNS resolution above. By the way, is the DNS request even needed there? Either way, I couldn't find any other places where a timeout could be added. I'm also not sure if Go allows us to set a timeout for net.ResolveUDPAddr, but I'll keep looking.

adguard pushed a commit that referenced this issue Dec 10, 2020
Merge in DNS/adguard-home from 2301-dhcp-check to master

Closes #2301.

Squashed commit of the following:

commit bf5c31b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Nov 13 14:28:54 2020 +0300

    dhcpd: fix possible infinite loop, set timeouts better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants