Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary "querylog: didn't find timestamp" error in the log #2324

Closed
ameshkov opened this issue Nov 17, 2020 · 0 comments
Closed

Unnecessary "querylog: didn't find timestamp" error in the log #2324

ameshkov opened this issue Nov 17, 2020 · 0 comments
Assignees
@EugeneOne1
Labels
bug P4: Low
Milestone
v0.104.2

Comments

@ameshkov
Copy link
Member

It's printed every time the log scanner switches to the next file.

I think we should distinguish this case and not print any errors.
@ameshkov ameshkov added this to the v0.104.2 milestone Nov 17, 2020
@ainar-g ainar-g assigned EugeneOne1 and unassigned ainar-g Nov 17, 2020
adguard pushed a commit that referenced this issue Dec 10, 2020
@EugeneOne1 @Blakhard
Pull request: querylog bug fix
deda159 
Merge in DNS/adguard-home from 2324-querylog-bug-fix to master

Closes #2324.

Squashed commit of the following:

commit fdd584a
Merge: 8103f9e f2eda6d
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Nov 18 15:35:42 2020 +0300

    Merge branch 'master' into 2324-querylog-bug-fix

commit 8103f9e
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Nov 18 14:28:29 2020 +0300

    querylog: fix the file ordering bug

commit 2c4e8fc
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Nov 17 20:57:45 2020 +0300

    querylog: wrap errors to clarify error trace

commit 3733062
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Nov 17 18:55:17 2020 +0300

    querylog: fix logger output bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P4: Low
Projects
None yet
Milestone
v0.104.2
Development

No branches or pull requests
3 participants
@ainar-g @ameshkov @EugeneOne1