Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/pprof handlers exposed #2336

Closed
ainar-g opened this issue Nov 19, 2020 · 0 comments
Closed

net/http/pprof handlers exposed #2336

ainar-g opened this issue Nov 19, 2020 · 0 comments
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.104.3

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Nov 19, 2020

In #2239 we falsely assumed that our code doesn't use http.DefaultServeMux and imported net/http/pprof, the handlers of which are now registered automatically and exposed. Fix ASAP!
@ainar-g ainar-g added this to the v0.104.3 milestone Nov 19, 2020
@ainar-g ainar-g self-assigned this Nov 19, 2020
adguard pushed a commit that referenced this issue Dec 10, 2020
@ainar-g @Blakhard
Pull request: home: add a patch against the global pprof handlers
b8d15eb 
Merge in DNS/adguard-home from 2336-pprof to master

Closes #2336.

Squashed commit of the following:

commit 855e133
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Nov 19 14:49:22 2020 +0300

    home: add a patch against the global pprof handlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.104.3
Development

No branches or pull requests
1 participant
@ainar-g