Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP options with multiple IPs #2385

Closed
ainar-g opened this issue Dec 2, 2020 · 1 comment
Closed

DHCP options with multiple IPs #2385

ainar-g opened this issue Dec 2, 2020 · 1 comment

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Dec 2, 2020

Context.

Currently, we have two option formats for our DHCP server: the hex format (1 hex abcd1234) and the IP format (1 ip 127.0.0.1). A common use for the second format is setting custom DNS servers with option 6. But in many cases we want at least two DNS addresses. So, we should either create a new type of option (something like 1 ips 127.0.0.1 127.0.0.2), patch the IP option to accept multiple IPs, or define rules for merging options together.

@ameshkov ameshkov added this to the v0.106 milestone Dec 2, 2020
adguard pushed a commit that referenced this issue Mar 15, 2021
Updates #2385.

Squashed commit of the following:

commit ce8467f
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Mar 15 19:02:17 2021 +0300

    dhcpd: add ips and text option types
@ainar-g
Copy link
Contributor Author

ainar-g commented Mar 16, 2021

As of snapshot e6a8fe4 we have added the two new DHCP option types: ips and text.

@loll31, values for options 6 and 252, which you were interested in, can now be spelled more clearly:

#
'dhcp':
  #
  'dhcpv4':
    #
    'options':
    - '6 ips 192.168.1.1,192.168.1.2'
    - '252 text socks://proxy.example.org'

We will soon update the Wiki as well.

@ainar-g ainar-g closed this as completed Mar 16, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2385.

Squashed commit of the following:

commit ce8467f
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Mar 15 19:02:17 2021 +0300

    dhcpd: add ips and text option types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants