Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS answer in query log is sometimes not a string #2609

Closed
ainar-g opened this issue Jan 28, 2021 · 3 comments
Closed

DNS answer in query log is sometimes not a string #2609

ainar-g opened this issue Jan 28, 2021 · 3 comments
Assignees
@ainar-g
Labels
bug P3: Medium
Milestone
v0.105.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Jan 28, 2021

Context: #2533 (comment).

Stop lying to the frontend that we send a string and make sure that we actually always send a string.
@ainar-g ainar-g added this to the v0.105.0 milestone Jan 28, 2021
@ainar-g ainar-g self-assigned this Jan 28, 2021
adguard pushed a commit that referenced this issue Jan 28, 2021
@ainar-g
Pull request: querylog: make answer actually a string
3af079a 
Merge in DNS/adguard-home from 2609-dns-answer-string to master

Updates #2609.

Squashed commit of the following:

commit 1922f90
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jan 28 15:19:11 2021 +0300

    querylog: stricter typing

commit 6ef73a4
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jan 28 15:04:06 2021 +0300

    querylog: make answer actually a string
@ainar-g
Copy link
Contributor Author

ainar-g commented Jan 28, 2021

@DandelionSprout, this should fixed as of snapshot 3af079a. Can you please check if our solution fixes the issue for you?

@ainar-g
Copy link
Contributor Author

ainar-g commented Feb 1, 2021

I'll close this issue for now. Please feel free to reopen if the problem isn't actually fixed for you.

@ainar-g ainar-g closed this as completed Feb 1, 2021
@DandelionSprout
Copy link
Member

Seems to be fixed as of 0.105.0-beta.3 (I lacked time to switch to the nightly buildd last week):
image

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: querylog: make answer actually a string
04514ec 
Merge in DNS/adguard-home from 2609-dns-answer-string to master

Updates AdguardTeam#2609.

Squashed commit of the following:

commit 1922f90
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jan 28 15:19:11 2021 +0300

    querylog: stricter typing

commit 6ef73a4
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jan 28 15:04:06 2021 +0300

    querylog: make answer actually a string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.105.0
Development

No branches or pull requests
2 participants
@ainar-g @DandelionSprout