Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API /control/dhcp/status returns key RangeStart instead of range_start inside 'v6' object #2678

Closed
jojost1 opened this issue Feb 13, 2021 · 2 comments
Assignees
Milestone

Comments

@jojost1
Copy link

jojost1 commented Feb 13, 2021

Issue Details

  • Version of AdGuard Home server:
    v0.105.0
  • How did you install AdGuard Home:
    Source
  • How did you setup DNS configuration:
    System
  • If it's a router or IoT, please write device model:
    Raspberry Pi Zero W

Expected Behavior

The 'v6' object in /control/dhcp/status returns:
"v6":{"range_start":"","lease_duration":86400}

Actual Behavior

The 'v6' object in /control/dhcp/status returns:
"v6":{"RangeStart":"","lease_duration":86400}

Additional Information

All of a sudden I'm seeing a key RangeStart instead of the expected range_start. I'm not using the DHCP server at the moment. The full response I'm getting:
{"enabled":false,"interface_name":"","v4":{"gateway_ip":"","subnet_mask":"","range_start":"","range_end":"","lease_duration":86400},"v6":{"RangeStart":"","lease_duration":86400},"leases":[],"static_leases":[{"mac":"18:3e:ef:c3:e8:56","ip":"192.168.1.42","hostname":"M1-Air","expires":"1970-01-01T01:00:01+01:00"}]}

@ameshkov ameshkov added this to the v0.105.1 milestone Feb 13, 2021
adguard pushed a commit that referenced this issue Feb 15, 2021
Merge in DNS/adguard-home from 2678-json-tag to master

Updates #2678.

Squashed commit of the following:

commit 7c272ae
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Feb 15 13:14:16 2021 +0300

    all: doc changes

commit 3c964f8
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Feb 15 12:54:27 2021 +0300

    dhcpd: fix dhcpv6 status json
@ainar-g
Copy link
Contributor

ainar-g commented Feb 15, 2021

Should be fixed on the edge channel as of snapshot aebcd74. Can you please recheck?

@jojost1
Copy link
Author

jojost1 commented Feb 15, 2021

Hi, I can confirm it's fixed! Fresh install on edge channel gives:
{"enabled":false,"interface_name":"","v4":{"gateway_ip":"","subnet_mask":"","range_start":"","range_end":"","lease_duration":0},"v6":{"range_start":"","lease_duration":0},"leases":[],"static_leases":[]}

@ainar-g ainar-g closed this as completed Feb 15, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2678-json-tag to master

Updates AdguardTeam#2678.

Squashed commit of the following:

commit 7c272ae
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Feb 15 13:14:16 2021 +0300

    all: doc changes

commit 3c964f8
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Feb 15 12:54:27 2021 +0300

    dhcpd: fix dhcpv6 status json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants