Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify and fix static leases and autohosts with disabled DHCP servers #2934

Closed
ainar-g opened this issue Apr 8, 2021 · 1 comment
Closed

Clarify and fix static leases and autohosts with disabled DHCP servers #2934

ainar-g opened this issue Apr 8, 2021 · 1 comment
Assignees
@ainar-g
Labels
bug enhancement P3: Medium
Milestone
v0.106.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Apr 8, 2021

  1. Configure and enable the DHCP server.

  2. Add a valid static lease, for example myhost.

  3. Make a DNS query for myhost.lan and get a successful response.

    So far so good.

  4. Disable the DHCP server without restarting AGH.

  5. Make a DNS query for myhost.lan and get a successful response.

    I'm not sure that this is intended.

  6. Restart AGH.

  7. Make a DNS query for myhost.lan and get an NXDOMAIN.

    I think this is intended, but this is inconsistent with the result from the request after disabling the DHCP server and before restarting AGH.

@ameshkov, I think that we should respond with NXDOMAIN on step 5 here. What do you think?
@ainar-g ainar-g self-assigned this Apr 8, 2021
@ameshkov
Copy link
Member

Probably you're right, we should respond with NXDOMAIN

@ainar-g ainar-g added this to the v0.106.0 milestone Apr 14, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: do not use dhcp clients when server is off
4e92ac2 
Closes AdguardTeam#2934.

Squashed commit of the following:

commit 856ea4e
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Apr 15 17:39:46 2021 +0300

    dnsforward: imp spacing

commit fa748e5
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Apr 15 17:33:44 2021 +0300

    dnsforward: imp code

commit 771ba0d
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Apr 15 17:06:03 2021 +0300

    all: do not use dhcp clients when server is off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug enhancement P3: Medium
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
2 participants
@ainar-g @ameshkov