Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting of upstream in client settings is not working #2947

Closed
Alex-302 opened this issue Apr 12, 2021 · 6 comments
Closed

Commenting of upstream in client settings is not working #2947

Alex-302 opened this issue Apr 12, 2021 · 6 comments
Assignees
@ainar-g
Labels
bug P3: Medium
Milestone
v0.106.0

Comments

@Alex-302
Copy link
Member

Issue Details

  • Version of AdGuard Home server: 0.105.2
  • How did you install AdGuard Home: Github releases
  • How did you setup DNS configuration: System
  • If it's a router or IoT, please write device model:
  • CPU architecture: x86
  • Operating system and version: Synology

Expected Behavior

Commented upstream is not used.

Actual Behavior

Commented upstream is used.

Steps to reproduce

Add to client settings

https://dns-unfiltered.adguard.com/dns-query
https://dns.adguard.com/dns-query

comment the first or second upstream and check result on http://adguard.com/test.html or by resolving googleads.g.doubleclick.net
When https://dns.adguard.com/dns-query is commented, googleads.g.doubleclick.net cannot be resolved on test page show

You are using "Default" AdGuard DNS configuration
Protocol: "DNS-over-HTTPS"
Server: "dns2-vultr-ams-4"

instead on non-filtered.
@Alex-302 Alex-302 added the bug label Apr 12, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Apr 12, 2021

Hi, thanks for the report. We cannot reproduce the issue. Do you also uncheck the “Use global settings” checkmark for this client? Because if not, the usual filters of AdGuard Home still apply.

@ainar-g ainar-g added the waiting for data Waiting for users to provide more data. label Apr 12, 2021
@Alex-302
Copy link
Member Author

I see Use global... in Settings and Block specific services only, but not in Upstream DNS servers
My client settings
image

@ainar-g
Copy link
Contributor

ainar-g commented Apr 12, 2021

That is what I meant. When “Use global settings” is checked, your local AGH's settings will apply to the client, including the filter lists, some of which might contain googleads.g.doubleclick.net.

@Alex-302
Copy link
Member Author

Global DNS: https://dns-unfiltered.adguard.com/dns-query

  • changed client's DNS to quic://dns-unfiltered.adguard.com:784 => Protocol: "DNS-over-QUIC" on the test page
  • changed client's DNS to tls://dns-unfiltered.adguard.com => Protocol: "DNS-over-TLS" on the test page
  • added both tls://dns-unfiltered.adguard.com and quic://dns-unfiltered.adguard.com:784 => Protocol: "DNS-over-QUIC" on the test page
  • commented the first => Protocol: "DNS-over-HTTPS" on the test page - used global.
# tls://dns-unfiltered.adguard.com
quic://dns-unfiltered.adguard.com:784
  • commented the second => Protocol: "DNS-over-HTTPS" on the test page - used global.
tls://dns-unfiltered.adguard.com
# quic://dns-unfiltered.adguard.com:784

@Alex-302
Copy link
Member Author

including the filter lists, some of which might contain googleads.g.doubleclick.net

Lists are disabled, own rules are limited by clients.

@ainar-g ainar-g self-assigned this Apr 12, 2021
@ainar-g ainar-g added P3: Medium and removed waiting for data Waiting for users to provide more data. labels Apr 12, 2021
@ainar-g ainar-g added this to the v0.106.0 milestone Apr 12, 2021
adguard pushed a commit that referenced this issue Apr 13, 2021
@ainar-g
Pull request: all: fix client custom upstream comments
48d702f 
Updates #2947.

Squashed commit of the following:

commit 498a054
Merge: 6a7a2f8 21e2c41
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 13 13:40:29 2021 +0300

    Merge branch 'master' into 2947-cli-ups-comment

commit 6a7a2f8
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 13 13:34:28 2021 +0300

    all: imp code, tests

commit abc0be2
Merge: 82fb3fc 6410fee
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 13 13:17:09 2021 +0300

    Merge branch 'master' into 2947-cli-ups-comment

commit 82fb3fc
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Apr 12 22:13:41 2021 +0300

    all: fix client custom upstream comments
@Alex-302
Copy link
Member Author

fixed in v0.106.0-a.122+d7b2d63e

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: fix client custom upstream comments
463153a 
Updates AdguardTeam#2947.

Squashed commit of the following:

commit 498a054
Merge: 6a7a2f8 21e2c41
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 13 13:40:29 2021 +0300

    Merge branch 'master' into 2947-cli-ups-comment

commit 6a7a2f8
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 13 13:34:28 2021 +0300

    all: imp code, tests

commit abc0be2
Merge: 82fb3fc 6410fee
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 13 13:17:09 2021 +0300

    Merge branch 'master' into 2947-cli-ups-comment

commit 82fb3fc
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Apr 12 22:13:41 2021 +0300

    all: fix client custom upstream comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
2 participants
@ainar-g @Alex-302