Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider IDNAs in query log search #3012

Closed
ainar-g opened this issue Apr 27, 2021 · 0 comments
Closed

Consider IDNAs in query log search #3012

ainar-g opened this issue Apr 27, 2021 · 0 comments
Assignees
@EugeneOne1
Labels
feature request P3: Medium
Milestone
v0.107.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Apr 27, 2021 •
edited by EugeneOne1
Loading

  1. Make a query for an IDNA, for example яндекс.рф.
  2. Go to the Query Log page.
  3. Try searching for яндекс.рф.

Expected: successful search with the query from step 1 being shown.

Actual: no results, unless you enter the encoded domain name, xn--d1acpjx3f.xn--p1ai.
@ainar-g ainar-g self-assigned this Apr 27, 2021
@ainar-g ainar-g mentioned this issue Apr 27, 2021
Open
3 tasks
@EugeneOne1 EugeneOne1 assigned EugeneOne1 and unassigned ainar-g Jun 28, 2021
@EugeneOne1 EugeneOne1 added this to the v0.107.0 milestone Jun 28, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3012 idna search
37c82de 
Merge in DNS/adguard-home from 3012-idna-search to master

Closes AdguardTeam#3012.

Squashed commit of the following:

commit 6a9fbfe
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 29 21:28:10 2021 +0300

    querylog: add todo

commit 31292ba
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 29 21:21:46 2021 +0300

    querylog: imp docs, code

commit 35757f7
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 29 21:01:08 2021 +0300

    queerylog: fix idn case match

commit eecfc98
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 29 20:32:00 2021 +0300

    querylog: imp code, docs

commit 8aa6242
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 29 20:00:54 2021 +0300

    querylog: sup idn search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
feature request P3: Medium
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1