Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCP lease created with empty hostname #4745

Closed
Versty opened this issue Jul 15, 2022 · 1 comment
Closed

DHCP lease created with empty hostname #4745

Versty opened this issue Jul 15, 2022 · 1 comment
Assignees
@EugeneOne1
Labels
bug P4: Low
Milestone
v0.107.12

Comments

@Versty
Copy link

Versty commented Jul 15, 2022 •
edited by EugeneOne1
Loading

Issue Details

Steps to reproduce:

  1. Enable DHCP server
  2. Configure DHCP IPv4 settings
  3. Add DHCP static lease with name Example
  4. Use command udhcpc -x hostname:'Example' from the client with different MAC address to create a temporary lease with the same name.
  • Version of AdGuard Home server:
    • v.0107.8
  • How did you install AdGuard Home:
    • Snapcraft
  • How did you setup DNS configuration:
    • classic set up
  • If it's a router or IoT, please write device model:
    • Lenovo
  • CPU architecture:
    • AMD64
  • Operating system and version:
    • Ubuntu 20.04.4 LTS

Expected Behavior

Temporary lease created with the requested hostname

Actual Behavior

Temporary lease created with an empty hostname

Screenshots

Screenshot:

Additional Information
@ainar-g ainar-g self-assigned this Jul 15, 2022
@ainar-g ainar-g added the needs investigation Needs to be reproduced reliably. label Jul 15, 2022
@ainar-g ainar-g added this to the v0.107.9 milestone Jul 15, 2022
@ainar-g ainar-g modified the milestones: v0.107.9, v0.107.10 Aug 3, 2022
@ainar-g ainar-g modified the milestones: v0.107.10, v0.107.11 Aug 17, 2022
@ainar-g ainar-g added bug P4: Low and removed needs investigation Needs to be reproduced reliably. labels Aug 17, 2022
@ainar-g ainar-g removed their assignment Aug 17, 2022
@EugeneOne1
Copy link
Member

EugeneOne1 commented Aug 18, 2022 •
edited
Loading

@Versty, hello. Unfortunately, we can't reproduce it on our machines. Could you please collect a verbose log to help us troubleshoot the issue? It'll really help if you'll send those to devteam@adguard.com with the Issue 4745 in the subject. Thanks.

@EugeneOne1 EugeneOne1 added waiting for data Waiting for users to provide more data. and removed waiting for data Waiting for users to provide more data. labels Aug 18, 2022
@ainar-g ainar-g modified the milestones: v0.107.11, v0.107.12 Aug 19, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 4745 Fix DHCP hostnames
230e134 
Merge in DNS/adguard-home from 4745-fix-dhcp-hostnames to master

Closes AdguardTeam#4745.

Squashed commit of the following:

commit fe03c8e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Aug 23 18:16:16 2022 +0300

    dhcpd: imp code, naming

commit 7a71292
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Aug 23 18:10:12 2022 +0300

    dhcpd: add tests

commit bb14a4a
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Aug 23 14:58:29 2022 +0300

    dhcpd: imp code, docs

commit 2ada39f
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Aug 23 14:44:35 2022 +0300

    all: log changes

commit cbd3ed2
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Aug 23 14:40:54 2022 +0300

    dhcpd: imp option 81

commit 64dabb5
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Aug 23 14:10:15 2022 +0300

    dhcpd: fix empty hostname in static lease

commit 0df5d10
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Aug 23 13:34:31 2022 +0300

    dhcpd: report dupl hostnames of static lease
@SarmadBytes SarmadBytes mentioned this issue Mar 16, 2024
Open
@SarmadBytes SarmadBytes mentioned this issue Mar 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P4: Low
Projects
None yet
Milestone
v0.107.12
Development

No branches or pull requests
3 participants
@ainar-g @EugeneOne1 @Versty