Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hbr.org #189848

Closed
adguard-bot opened this issue Sep 29, 2024 · 13 comments
Closed

hbr.org #189848

adguard-bot opened this issue Sep 29, 2024 · 13 comments

Comments

@adguard-bot
Copy link

Issue URL (Annoyance)

https://hbr.org/2024/09/ai-can-mostly-outperform-human-ceos
Username: @rakleed

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information Value
AdGuard product: AdGuard for iOS v4.5.5
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Language-specific:
AdGuard Russian
@adguard-bot
Copy link
Author

Issue URL (Incorrect Blocking)

https://hbr.org/2024/09/ai-can-mostly-outperform-human-ceos

Comment

When AdGaurd is enabled, the header is not completely visible.

Also leftovers from social buttons, mobile app link, self-promo and email subscription.
Username: @rakleed

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

Screenshot 3

Screenshot 3

Screenshot 1 with AdGuard disabled

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for Mac v2.15.1.1731 release
Browser: Chrome
Tracking protection options: Strip URLs from tracking parameters,
Hide your search queries,
Hide your Referrer from third-parties,
Hide your User-Agent,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (180),
Disable cache for third-party requests,
Block trackers
DNS filtering: server: https://d.adguard-dns.com/dns-query/xxxxxxx
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection,
AdGuard URL Tracking

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Language-specific:
AdGuard Russian
Browsing Security: enabled
Browsing Security statistics: disabled
Userscripts: IMDb Tomatoes (url: https://update.greasyfork.org/scripts/15222/IMDb Tomatoes.user.js)
AdGuard Extra (url: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js)
Nova YouTube (url: https://openuserjs.org/install/raingart/Nova_YouTube.user.js)
Userstyles: disabled

Issue configuration

Import

@rakleed
Copy link
Contributor

rakleed commented Oct 3, 2024

Screenshots

AdGuard enabled:

image

image

image

AdGuard disabled:

image

@BlazDT BlazDT added the A: In progress Work on the issue is in progress label Oct 3, 2024
BlazDT added a commit that referenced this issue Oct 3, 2024
@BlazDT
Copy link
Contributor

BlazDT commented Oct 3, 2024

Broken header not reproduced, looks like something is hiding the class Standard_primary-ad-container. Please check filtering log.
Other elements hidden.

@BlazDT BlazDT added the A: Waiting for data Waiting for more information from the user label Oct 3, 2024
BlazDT added a commit that referenced this issue Oct 3, 2024
@rakleed
Copy link
Contributor

rakleed commented Oct 3, 2024

@BlazDT you should update the rule 2c1de6e#diff-573dc3f218d8218a83deb0f9a6c1b1969b357dc584dc49ee3133ee81e890dd16R85 to

hbr.org##ul[class^="PageUtils_container"] > li:not([class*="PageUtils_standard"]):has(> [data-analytics^="share"])

because now X icon still visible.

Also in macOS app, the rule 2c1de6e#diff-e34a1d9fc96c2d698dbb2e06d11bf42bd7297804b08911de57ee498d56ce84b7R21 doesn't work at all.

And about the header - it is displayed correctly while the page is loading, but when it is completely loaded, it is overlapped by the header. Attached the saved page: hbr-org-saved-page.html.zip

BlazDT added a commit that referenced this issue Oct 3, 2024
@BlazDT
Copy link
Contributor

BlazDT commented Oct 3, 2024

hbr.org##ul[class^="PageUtils_container"] > li:not([class*="PageUtils_standard"]):has(> [data-analytics^="share"])

because now X icon still visible.

Was not visible before, but now, updated.

Also in macOS app, the rule 2c1de6e#diff-e34a1d9fc96c2d698dbb2e06d11bf42bd7297804b08911de57ee498d56ce84b7R21 doesn't work at all.

Working fine on Chrome Extension, maybe bug in mac app

Regarding broken header:
Mentioned class Standard_primary-ad-container__woctl has the class sf-hidden added while mine not (also has children while yours not).

@zloyden please check on Mac, thank you.

@zloyden
Copy link
Contributor

zloyden commented Oct 4, 2024

@BlazDT not reproduced on my end.

@rakleed
Copy link
Contributor

rakleed commented Oct 4, 2024

The link to the mobile application is now always blocked after clearing the cache.

And now for some reason, the HTML of the page has changed. It comes like in #189848 (comment), and then like this: hbr-org-saved-page-2.html.zip

And when you open the site every time in a new Incognito tab, the header either hides or doesn’t. As I understand it, it depends on whether the hbr.org##div[data-testid="ad-container"] rule for hiding is applied to the parent. However, I couldn’t find such a rule in the filters. Could it really be a bug?


@zloyden @BlazDT I think I found steps to reproduce the issue. If your title is displayed correctly, then:

  1. To the left of the URL in Chrome, click the settings icon (View site information).
  2. Select Cookies and site data.
  3. Then Manage on-device site data.
  4. Then delete all the data that is there.
  5. Then open the developer tools.
  6. Right-click the reload icon to the left of the URL and select Empty cache and hard reload.

I don't know if this is a browser bug related to SSG, or AdGuard.

BlazDT added a commit that referenced this issue Oct 5, 2024
@BlazDT
Copy link
Contributor

BlazDT commented Oct 5, 2024

Followed your steps, header not broken. Could you please check on Safari, thank you.

Fixed cookie dialogue on site.

@rakleed
Copy link
Contributor

rakleed commented Oct 13, 2024

I can reproduce the problem in Safari even if I delete the site cache.

I made a screen recording with steps on how to reproduce the problem in Chrome. Can you please check if you are missing anything?

CleanShot.2024-10-13.at.22.17.55.mp4

@BlazDT
Copy link
Contributor

BlazDT commented Oct 16, 2024

@AdguardTeam/filters-maintainers please check, thank you.

AdamWr added a commit that referenced this issue Oct 17, 2024
@AdamWr
Copy link
Member

AdamWr commented Oct 17, 2024

On my end it was caused by this rule:

hbr.org##div[data-params="region=openx;location=leaderboard"]

I have removed it and added another rule to fix ad leftover on the main page.

@rakleed
Copy link
Contributor

rakleed commented Oct 17, 2024

@AdamWr thanks! Now it always correctly shows the article title.

@AdamWr
Copy link
Member

AdamWr commented Oct 17, 2024

Thank you for your reply.
I guess that it can be closed now.

@AdamWr AdamWr closed this as completed Oct 17, 2024
@AdamWr AdamWr added A: Resolved and removed A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants