Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'prevent-xhr' and 'trusted-replace-xhr-response' — mock getResponseHeader() and getAllResponseHeaders() methods #295

Closed
piquark6046 opened this issue Mar 1, 2023 · 0 comments
Closed

Fix 'prevent-xhr' and 'trusted-replace-xhr-response' — mock getResponseHeader() and getAllResponseHeaders() methods #295

piquark6046 opened this issue Mar 1, 2023 · 0 comments
Assignees
@slavaleleka
Labels
bug Something isn't working Priority: P4 Release: v1.9.37 Resolution: Fixed Status: Closed Version: Scriptlets v1.9

Comments

@piquark6046
Copy link
Member

piquark6046 commented Mar 1, 2023 •
edited by slavaleleka
Loading

Expected and Actual Behaviors

Screencast:
Screencast.from.2023-03-01.11-28-18.webm 
#%#//scriptlet('prevent-xhr', 'https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js')
||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js$redirect=googlesyndication-adsbygoogle
@@||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js

Environment

  • Operating System: Ubuntu 22.10
  • Web Browser: Mozilla Firefox Developer Edition 111.0b7
  • AdGuard product: AdGuard Browser extension 4.1.53 (standalone)

Additional Information
@piquark6046 piquark6046 added the bug Something isn't working label Mar 1, 2023
@piquark6046 piquark6046 changed the title XMLHttpRequest.prototype.getResponseHeader issue in scriptlet and redirect 'XMLHttpRequest.prototype.getResponseHeader' issue in scriptlet and redirect Mar 1, 2023
@piquark6046 piquark6046 mentioned this issue Mar 1, 2023
Open
8 tasks
@adguard-bot adguard-bot changed the title 'XMLHttpRequest.prototype.getResponseHeader' issue in scriptlet and redirect 'XMLHttpRequest.prototype.getResponseHeader()' issue in scriptlet and redirect Mar 1, 2023
@adguard-bot adguard-bot assigned maximtop and unassigned zzebrum Mar 3, 2023
@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop May 11, 2023
adguard pushed a commit that referenced this issue May 16, 2023
@slavaleleka
mock getResponseHeader() and getAllResponseHeaders() methods for prev…
4d40094 
…ent-xhr

#295 AG-20196

Squashed commit of the following:

commit 8bd6739
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 18:07:12 2023 +0300

    no deprecated helper startsWith() usage

commit a0e0db1
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 17:59:14 2023 +0300

    fix trusted-replace-xhr-response

commit ef04555
Merge: 0efb80e 6af803c
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 17:42:45 2023 +0300

    merge master, resolve conflicts

commit 0efb80e
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 14:25:41 2023 +0300

    update changelog

commit f9c6da7
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 14:23:22 2023 +0300

    update changelog

commit e15e923
Merge: 10c0393 71d7683
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 14:22:13 2023 +0300

    merge master, resolve conflicts

commit 10c0393
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 14:15:31 2023 +0300

    add comments for getHeaderWrapper() and getAllHeadersWrapper()

commit 8ff8421
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 13:34:36 2023 +0300

    add todo for array destructuring

commit 7762018
Merge: e8760f3 66582ca
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue May 16 12:16:54 2023 +0300

    Merge branch 'master' into fix/AG-20196

commit e8760f3
Merge: 35074e5 b13ae17
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon May 15 11:53:57 2023 +0300

    Merge branch 'fix/AG-20196' of ssh://bit.adguard.com:7999/adguard-filters/scriptlets into fix/AG-20196

commit 35074e5
Merge: eb1d72a 898998d
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon May 15 11:53:11 2023 +0300

    Merge branch 'master' into fix/AG-20196

commit b13ae17
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri May 12 18:06:13 2023 +0300

    improve error text

commit 93c3b6b
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri May 12 18:04:11 2023 +0300

    fix changelog

commit eb1d72a
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri May 12 14:15:39 2023 +0300

    update changelog

commit f62fc97
Merge: b378dd4 b96e797
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri May 12 13:50:37 2023 +0300

    Merge branch 'master' into fix/AG-20196

commit b378dd4
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri May 12 13:49:31 2023 +0300

    improve prevent-xhr - add mock getResponseHeader() and getAllResponseHeaders() methods
@adguard-bot adguard-bot mentioned this issue Jul 27, 2023
Closed
@adguard-bot adguard-bot changed the title 'XMLHttpRequest.prototype.getResponseHeader()' issue in scriptlet and redirect mock getResponseHeader() and getAllResponseHeaders() methods for prevent-xhr and trusted-replace-xhr-response Sep 11, 2023
@adguard-bot adguard-bot changed the title mock getResponseHeader() and getAllResponseHeaders() methods for prevent-xhr and trusted-replace-xhr-response Fix 'prevent-xhr' and 'trusted-replace-xhr-response' — mock getResponseHeader() and getAllResponseHeaders() methods Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
bug Something isn't working Priority: P4 Release: v1.9.37 Resolution: Fixed Status: Closed Version: Scriptlets v1.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maximtop @adguard-bot @zzebrum @slavaleleka @piquark6046