(chore): Switch from yarn v3 to pnpm #92

AdiRishi · 2023-09-18T23:26:42Z

Resolves #84

Summary by CodeRabbit

Chore:

Switched from yarn to pnpm as the package manager across all project files and documentation for improved package management and dependency resolution.
Updated GitHub Actions workflows (ci.yml and deploy.yml) to use pnpm for installing dependencies, linting, type checking, building, and testing.
Added a new event trigger in deploy.yml to run the workflow on pull requests targeting the master branch.

Documentation:

Updated installation and setup instructions in README.md and .github/CONTRIBUTING.md to reflect the switch to pnpm.
Updated commands for running linting and tests in README.md and .github/CONTRIBUTING.md to use pnpm.

coderabbitai · 2023-09-18T23:26:46Z

Rate Limit Exceeded

@AdiRishi has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 14 minutes and 56 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, convert this PR to a draft and then mark it as ready for review again to re-trigger the review. Alternatively, you can push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per repository.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 1b24811 and e27f179.

Walkthrough

This pull request primarily focuses on transitioning the project's package management from yarn to pnpm. The changes span across documentation, CI/CD workflows, and setup instructions, ensuring a consistent use of pnpm for dependency resolution, linting, testing, building, and deployment.

Changes

File(s)	Summary
`.github/CONTRIBUTING.md`, `README.md`	Updated documentation to replace `yarn` commands with `pnpm` for installing dependencies and running scripts.
`.github/workflows/ci.yml`, `.github/workflows/deploy.yml`	Modified GitHub Actions workflows to use `pnpm` instead of `yarn` for package management. Added `pnpm/action-setup` action to install pnpm version 8. Also added a new trigger event for pull requests on the `master` branch in `deploy.yml`.

🐇💻

In the land of code where the shadows lie,

We bid farewell to Yarn, with a gentle sigh.

PNPM now reigns, swift and lean,

For efficient builds, it's the new queen! 👑🎉

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

Mention @coderabbitai in any review comment for bot assistance.
Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
resume reviews, enter @coderabbitai resume as any issue or review comment.

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 4cd137e and 93a018e commits.

Files ignored due to filter (3)

package.json
pnpm-lock.yaml
yarn.lock

Files selected for processing (4)

.github/CONTRIBUTING.md (1 hunks)
.github/workflows/ci.yml (1 hunks)
.github/workflows/deploy.yml (1 hunks)
README.md (3 hunks)

Files skipped from review due to trivial changes (3)

.github/CONTRIBUTING.md
.github/workflows/ci.yml
README.md

Additional comments (Suppressed): 3

.github/workflows/deploy.yml (3)

14-17: The pnpm/action-setup@v2 action is used to set up pnpm, but the version specified is 8. Please verify if this is the intended version of pnpm to be used.

20-20: Good job on updating the cache option from 'yarn' to 'pnpm'. This will ensure that the correct package manager's cache is used.

21-21: The command for installing dependencies has been correctly updated from yarn install to pnpm install.

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 93a018e and 0f02c09.

Files selected for processing (1)

.github/workflows/deploy.yml (1 hunks)

Files skipped from review due to trivial changes (1)

.github/workflows/deploy.yml

coderabbitai

Review Status

Actionable comments generated: 1

Commits

Files that changed from the base of the PR and between 0f02c09 and 0e05880.

Files selected for processing (1)

.github/workflows/deploy.yml (1 hunks)

Additional comments (Suppressed): 2

.github/workflows/deploy.yml (2)

7-8: The deploy.yml workflow now triggers on pull requests targeting the master branch. This is a significant change and could potentially lead to deployments happening more frequently than intended, especially if your team creates a lot of pull requests. Please verify that this is the desired behavior.

16-18: You are using pnpm/action-setup@v2 to set up pnpm with version 8. Ensure that all dependencies of your project are compatible with this version of pnpm.

coderabbitai · 2023-09-20T23:01:04Z

.github/workflows/deploy.yml

      - name: Deploy
-        uses: cloudflare/wrangler-action@v3
+        uses: cloudflare/wrangler-action@master


You have changed the version of cloudflare/wrangler-action from v3 to master. Using the master branch can be risky as it may contain unstable changes. Consider pinning to a specific stable version or a release tag.

coderabbitai · 2023-09-20T23:02:33Z

Rate Limit Exceeded

You have exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 29 minutes and 59 seconds before requesting another review.

To re-trigger a review, convert this PR to a draft and then mark it as ready for review again. Alternatively, you can push a new commit to this PR.

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 4cd137e and 93a018e.

Files ignored due to filter (3)

package.json
pnpm-lock.yaml
yarn.lock

Files selected for processing (4)

.github/CONTRIBUTING.md (1 hunks)
.github/workflows/ci.yml (1 hunks)
.github/workflows/deploy.yml (1 hunks)
README.md (3 hunks)

Files skipped from review due to trivial changes (4)

.github/CONTRIBUTING.md
.github/workflows/ci.yml
.github/workflows/deploy.yml
README.md

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 52aa8c2 and c039f16.

Files ignored due to filter (3)

package.json
pnpm-lock.yaml
yarn.lock

Files selected for processing (4)

.github/CONTRIBUTING.md (1 hunks)
.github/workflows/ci.yml (1 hunks)
.github/workflows/deploy.yml (1 hunks)
README.md (3 hunks)

Files skipped from review due to trivial changes (3)

.github/CONTRIBUTING.md
.github/workflows/ci.yml
README.md

Additional comments (Suppressed): 2

.github/workflows/deploy.yml (2)

14-16: The pnpm/action-setup@v2 action is used to set up PNPM. Ensure that the version specified (8) is compatible with the project's dependencies and does not introduce breaking changes.

20-21: The cache option has been updated from 'yarn' to 'pnpm', and the command for installing dependencies has been changed from yarn install to pnpm install. Verify that these changes have been reflected in all relevant parts of the codebase, including documentation and scripts.

This reverts commit 1b24811.

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between c039f16 and 1b24811.

Files selected for processing (1)

.github/workflows/deploy.yml (1 hunks)

Files skipped from review due to trivial changes (1)

.github/workflows/deploy.yml

coderabbitai bot reviewed Sep 18, 2023

View reviewed changes

coderabbitai bot reviewed Sep 20, 2023

View reviewed changes

AdiRishi force-pushed the arishi-pnpm branch from 09c4a74 to 93a018e Compare September 21, 2023 02:14

coderabbitai bot reviewed Sep 21, 2023

View reviewed changes

Switch from yarn v3 to pnpm

c039f16

AdiRishi force-pushed the arishi-pnpm branch from 93a018e to c039f16 Compare October 3, 2023 06:37

coderabbitai bot reviewed Oct 3, 2023

View reviewed changes

AdiRishi added 2 commits October 3, 2023 17:40

Attempt to deploy in PR

1b24811

Revert "Attempt to deploy in PR"

e27f179

This reverts commit 1b24811.

coderabbitai bot reviewed Oct 3, 2023

View reviewed changes

AdiRishi merged commit 8b42468 into master Oct 3, 2023
4 checks passed

AdiRishi deleted the arishi-pnpm branch October 3, 2023 06:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(chore): Switch from yarn v3 to pnpm #92

(chore): Switch from yarn v3 to pnpm #92

AdiRishi commented Sep 18, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 18, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

Pause Incremental Reviews

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot Sep 20, 2023

coderabbitai bot commented Sep 20, 2023

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

(chore): Switch from yarn v3 to pnpm #92

(chore): Switch from yarn v3 to pnpm #92

Conversation

AdiRishi commented Sep 18, 2023 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Sep 18, 2023 • edited Loading

Rate Limit Exceeded

Walkthrough

Changes

Chat with CodeRabbit Bot (@coderabbitai)

Pause Incremental Reviews

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Sep 20, 2023

Choose a reason for hiding this comment

coderabbitai bot commented Sep 20, 2023

Rate Limit Exceeded

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

AdiRishi commented Sep 18, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 18, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)