fix(touchbar): extend search string to exclude false replacements #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the new section added to the config now 2 lines could be find by the sed with `primary_layer.*` condition. And because of that the replacement brakes the config file. So we need to extend the search string to exclude the section. The same changes should be done for `secondary_layer.*` condition
|
Shall be added to 0.1.4-2. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the new sections added to the config now 2 lines could be find by the sed with
primary_layer.*condition. And because of that the replacement brakes the config file.So we need to extend the search string to exclude the section.
The same changes should be done for
secondary_layer.*condition