Fix 'slice bounds out of range' in DeleteMessageBatch #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug inside
DeleteMessageBatch
function (issue #171):Basically what is happening, first we iterate over messages with index
i
and when we delete we override the messages. But once we delete an element from messages the indexi
from the outer loop is already outdated and we can't rely on it.The solution is to switch loops, iterate over
deleteEntries
first and then start looking for message to be deleted, so indexi
always will be actual.