Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to derive queue url host, tidying up logging levels #234

Closed
wants to merge 7 commits into from

Conversation

nhoughto
Copy link

No description provided.

@Admiral-Piett
Copy link
Owner

@nhoughto @AndrewChubatiuk Sorry this took ages to respond to, I'm ramping up on this after taking of the repo. Looks like you guys have 2 pretty similar PR's out there. This one and @AndrewChubatiuk 's here - #213.

It looks like you're wanting to determine the host from the incoming header as opposed to just automatically routing to resources on the same host that's accepting your request. If that's true, what's your use case for this pattern? Are you running multiple goaws instances at once and wanting to route requests between them?

@Admiral-Piett
Copy link
Owner

Following up here @nhoughto @AndrewChubatiuk - would you mind speaking a little more to my question here around the use case on this?

#234 (comment)

@AndrewChubatiuk
Copy link

hey @Admiral-Piett i was trying to query service from both host and docker networks that why goaws should return a valid urls depending on a network it was queried from

@Admiral-Piett
Copy link
Owner

@AndrewChubatiuk @nhoughto Closing this as a duplicate in favor of #213. I am still reviewing the implementation, but I think the logging features and some of the other additions could be separate PRs. If they're still something either of you wants to move forward with - let's discuss them further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants