Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe access to PATH #756

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Conversation

BowDown097
Copy link
Contributor

@BowDown097 BowDown097 commented Jul 31, 2024

This addresses #755 - an immediate crash due to a KeyError when PATH is not present in os.environ (which is the case when the service is ran through dinit).

@shadeyg56 shadeyg56 linked an issue Jul 31, 2024 that may be closed by this pull request
@AdnanHodzic
Copy link
Owner

LGTM, Thank you for your contribution, you will be credited for your work as part of future release.

@AdnanHodzic AdnanHodzic merged commit a1ac308 into AdnanHodzic:master Aug 4, 2024
2 checks passed
shadeyg56 added a commit that referenced this pull request Aug 5, 2024
* added the abilty to ignore certain power supplies

* changed config file for ignoring power supplies

* updated exapmle config file for ignoring power supplies

* updated docs with ignoring power supplies

* Update README.md

Update image URL's

* Add support for setting "Platform Profile" (#752)

* Add support for setting "Platform Profile"

* Add reference for Platform Profile

* Fix unsafe access to PATH (#756)

* Fix unsafe access to PATH

* Fix leading separator if PATH is empty

* Unpin psutil and requests (#759)

* Remove network-online.target as a systemd-service dependency (improve boot time). Closes: #739

* minor grammer correction.

* removed wonky file

---------

Co-authored-by: Adnan Hodzic <adnan@hodzic.org>
Co-authored-by: Harsh Panchal <BOOTMGR@users.noreply.github.com>
Co-authored-by: BowDown097 <42720004+BowDown097@users.noreply.github.com>
Co-authored-by: shadeyg56 <31134255+shadeyg56@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Immediate crash in dinit service (+ FIX)
2 participants