ACS AEM Commons Touch UI Multifield Extension #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| (function () { | ||
| var DATA_ACS_AEM_NESTED = "data-acs-aem-nested", |
There was a problem hiding this comment.
Can we change this to data-acs-commons-nested ? the "aem" part is IMHO unnecessary (as we're obviously in AEM 😄 )
There was a problem hiding this comment.
sure, makes sense, and btw i am going to implement all review comments at one go, eod
…ckager add support for QueryBuilder-map based queries in Query Packager
node naming conventions
435 - Added context path to ACS Commons utilities
…efixing-servlet CQInclude Property Namespace Servlet
|
This looks good to me. Any other comments before merging? |
|
none from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New clientlib "touchui-widgets" extending ootb "cq.authoring.dialog" clientlib providing the composite multifield capability