Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement In-App DevEx v2 #78

Merged
merged 15 commits into from
May 21, 2024
Merged

Implement In-App DevEx v2 #78

merged 15 commits into from
May 21, 2024

Conversation

undavide
Copy link
Collaborator

Description

Implement UI/UX changes in the in-app distribution experiences. See this GDoc.

Affected documentation:

  • Getting Started > Quickstart guide
  • Distribute > Creating a private link
  • Distribute > Creating a public listing

⚠️ Caveats

In the future, it might be worth revisiting Step 9: Create a publisher profile in public-dist.md. Given that I've used the Stage version with a privileged account from the Test Privileged Dev Org - stage group, I could not simulate the creation of a publisher (it was already there). Admittedly, even the existing version of the documentation is pretty thin in that regard; it shouldn't be a problem now, but when the changes are pushed to production, one can use a personal account to document the publisher creation better.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@undavide undavide self-assigned this May 16, 2024
Copy link
Collaborator

@hollyschinsky hollyschinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hollyschinsky hollyschinsky merged commit 41def51 into main May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants