Uxp v7.4 #108
Merged
Uxp v7.4 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padmkris123
commented
Apr 11, 2024
| | [capture] | `boolean` | `false` | | ||
| | eventName | `*` | | | ||
| | callback | `*` | | | ||
| | options | `boolean` \| `Object` | Boolean value denoting capture value or options object. Currently supports only capture in options object ({ capture: bool_value }). | |
There was a problem hiding this comment.
@bhatiaPankaj @kareemmyk Can you confirm if these changes are intentional? The change to eventTarget also impacts a lot of HTMLElements.
padmkris123
commented
Apr 11, 2024
| @@ -25,7 +25,7 @@ Generates cryptographically strong random values | |||
|
|
|||
| | Param | Type | Description | | |||
| | --- | --- | --- | | |||
| | array | `*` | An integer-based TypedArray, that is one of Int8Array, Uint8Array, Uint8ClampedArray, Int16Array, Uint16Array, Int32Array, Uint32Array, BigInt64Array, BigUint64Array but not Float32Array nor Float64Array | | |||
| | array | `IntegerArray` | An integer-based TypedArray, that is one of Int8Array, Uint8Array, Uint8ClampedArray, Int16Array, Uint16Array, Int32Array, Uint32Array, BigInt64Array, BigUint64Array but not Float32Array nor Float64Array | | |||
There was a problem hiding this comment.
@kareemmyk @bhatiaPankaj Can you confirm if this change is required?
padmkris123
commented
Apr 11, 2024
|
|
||
| | Param | Type | Description | | ||
| | --- | --- | --- | | ||
| | init | `string` \| `Headers` | Object containing any HTTP headers you want to pre-populate your Headers with. | | ||
| | [init] | `Headers` \| `Array<{string, string}>` \| `Object` | An existing Headers object, an array of name-value pairs or object literal with string values. | |
There was a problem hiding this comment.
@kareemmyk @bhatiaPankaj Can you confirm if this change is required?
padmkris123
commented
Apr 11, 2024
| @@ -17,7 +18,7 @@ Request class represents a resource request. | |||
| | Param | Type | Description | | |||
| | --- | --- | --- | | |||
| | input | `string` \| `Request` | Defines the resource that you wish to fetch. This can either be: A string containing the URL of the resource you want to fetch. A Request object. | | |||
| | options | `Object` | 'Optional' object containing any custom settings that you want to apply to the request. | | |||
| | options | `Object` | '(Optional)' object containing any custom settings that you want to apply to the request. | | |||
There was a problem hiding this comment.
@kareemmyk @bhatiaPankaj Can you confirm if this change is required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: