Make dependency on magento/framework more open #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-compatible according to semver.
|
@hostep , Thank you for your work on our package. We will review it shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys
Big thank you for the translation pack, awesome work!
This pull request opens up the composer dependency on magento/framework version.
Otherwise you can't use this module in combination with Magento 2.1 (rc versions at the moment).
The caret type is the preferred way to set up version constraints, because right now your constraint only allowed changes on the third number. This fix will also allow the second number to change (which happens in Magento 2.1: 100.1.xxx).
Backwards incompatible changes happen when the first number changes, so as long as the magento/framework versions follow semver, everything should work out fine.