Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public helpers to improve Google Pay integration #1413

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

jreij
Copy link
Collaborator

@jreij jreij commented Dec 5, 2023

Description

  • The Google Pay button requires an AllowedPaymentMethods attribute. This PR allows getting this attribute directly from the Google Pay component by using GooglePayComponent.getGooglePayButtonParameters().
  • Made AllowedAuthMethods and AllowedCardNetworks public to provide easy access to the possible values for these attributes.

Checklist

  • Code is unit tested
  • Changes are tested manually
  • Add relevant labels to PR

COAND-830

@jreij jreij added the Feature [PRs only] Indicates a new feature addition label Dec 5, 2023
@jreij jreij requested a review from a team as a code owner December 5, 2023 17:07
It's basically just a wrapper around allowedPaymentMethods in case something else is required for the button later on
COAND-830
@jreij jreij force-pushed the feature/google_pay_allowed_payment_methods branch from 4a8ea6d to 74882b6 Compare December 6, 2023 09:59
@jreij jreij merged commit 0bf7868 into develop Dec 6, 2023
5 checks passed
@jreij jreij deleted the feature/google_pay_allowed_payment_methods branch December 6, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature [PRs only] Indicates a new feature addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants