Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/top bar navigation #1560

Merged
merged 17 commits into from
Jun 6, 2024
Merged

Feature/top bar navigation #1560

merged 17 commits into from
Jun 6, 2024

Conversation

araratthehero
Copy link
Contributor

@araratthehero araratthehero commented Apr 18, 2024 •
edited
Loading

Description

This PR includes the following changes:

  • Swipe to dismiss Drop-in has been removed
  • Top navigation has been added to all Drop-in screens
  • Bottom sheets do not have rounded corners anymore
  • Going back from actions now dismisses Drop-in, instead of opening it again
  • Gift card confirmation screen now has a title, which shows the payment method name

Checklist

  • Changes are tested manually
  • Link to related issues
  • Add relevant labels to PR

COAND-868

@araratthehero araratthehero requested a review from a team as a code owner April 18, 2024 14:16
jreij
jreij reviewed Apr 19, 2024
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
jreij
jreij reviewed Apr 19, 2024
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
@araratthehero araratthehero added the Feature [PRs only] Indicates a new feature addition label Apr 19, 2024
@araratthehero araratthehero marked this pull request as draft April 22, 2024 12:17
@araratthehero araratthehero marked this pull request as ready for review April 22, 2024 13:05
@araratthehero araratthehero force-pushed the feature/top_bar_navigation branch 3 times, most recently from 96bb38b to b0bcb95 Compare April 24, 2024 13:40
@araratthehero araratthehero force-pushed the feature/top_bar_navigation branch 4 times, most recently from cd11e33 to 8439e6a Compare April 29, 2024 07:19
@araratthehero araratthehero force-pushed the feature/top_bar_navigation branch 2 times, most recently from 56f5e89 to 0316dc4 Compare April 30, 2024 07:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@araratthehero araratthehero force-pushed the feature/top_bar_navigation branch 2 times, most recently from e5d0569 to 3ab05f1 Compare June 5, 2024 12:31
@araratthehero araratthehero requested a review from jreij June 6, 2024 10:21
jreij
jreij reviewed Jun 6, 2024
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
@araratthehero
Create DropInBottomSheetToolbarView which supports different modes fo…
377949e 
…r navigation button

COAND-868
@araratthehero
Make bottom sheets expanded by default
037f008 
COAND-868
@araratthehero
Add top bar support for BaseComponentDialogFragment
9b8a929 
COAND-868
@araratthehero
Add top bar support for CardComponentDialogFragment
13b2948 
COAND-868
@araratthehero
Add top bar support for BacsDirectDebitDialogFragment
fdd70a4 
COAND-868
@araratthehero
Add top bar support for GenericComponentDialogFragment
fec8de2 
COAND-868
@araratthehero
Add top bar support for GiftCardComponentDialogFragment
6429e98 
COAND-868
@araratthehero
Add top bar support for GiftCardPaymentConfirmationDialogFragment
3ded835 
COAND-868
@araratthehero
Add top bar support for ActionComponentDialogFragment
f33666f 
COAND-868
@araratthehero
Add top bar support for PaymentMethodListDialogFragment
9fce432 
COAND-868
@araratthehero
Add top bar support for PreselectedStoredPaymentMethodFragment
ad1dc47 
COAND-868
@araratthehero
Remove bottom sheet indicator
897fa90 
COAND-868
@araratthehero
Remove rounded corners for the bottom sheet
d2332af 
COAND-868
@araratthehero
Always close Drop-in when cancelling action
8db72dd 
COAND-868
@araratthehero
Add release notes
2bbff15 
COAND-868
@araratthehero
Fix the bug when the bottom sheet would collapse because of an oversc…
c75a7ef 
…roll in nested scrollview

COAND-868
@araratthehero
Adjust release notes
991da0b 
COAND-868
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@araratthehero araratthehero merged commit 494d2d8 into develop Jun 6, 2024
7 of 8 checks passed
@araratthehero araratthehero deleted the feature/top_bar_navigation branch June 6, 2024 12:47
This was linked to issues Jun 6, 2024
Replace the "swipe down" action with an explicit "Exit" button #1402
Closed
Drop In Component only partially extended on tablets #1623
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozgur00 ozgur00 ozgur00 left review comments

@jreij jreij jreij approved these changes

Assignees
No one assigned
Labels
Feature [PRs only] Indicates a new feature addition
Projects
None yet
Milestone
No milestone
3 participants
@araratthehero @ozgur00 @jreij