Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "UPI_Intent" flow UI #1674

Merged
merged 12 commits into from
May 31, 2024
Merged

Implement "UPI_Intent" flow UI #1674

merged 12 commits into from
May 31, 2024

Conversation

neelSharma12
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@neelSharma12 neelSharma12 added the new a pull request that adds a new feature label May 13, 2024
@neelSharma12 neelSharma12 marked this pull request as draft May 13, 2024 08:11
goergisn
goergisn reviewed May 13, 2024
View reviewed changes
AdyenComponents/UPI/UPIComponent.swift Outdated Show resolved Hide resolved
Adyen/UI/List/ListItem.swift Outdated Show resolved Hide resolved
Adyen/UI/List/ListItemView.swift Outdated Show resolved Hide resolved
erenbesel
erenbesel reviewed May 27, 2024
View reviewed changes
AdyenActions/Components/Await/AwaitComponent.swift Outdated Show resolved Hide resolved
AdyenActions/Actions/AwaitAction.swift Outdated Show resolved Hide resolved
AdyenActions/AdyenActionComponent.swift Outdated Show resolved Hide resolved
goergisn
goergisn reviewed May 28, 2024
View reviewed changes
AdyenActions/Components/Await/AwaitComponent.swift Outdated Show resolved Hide resolved
AdyenComponents/UPI/UPIComponent.swift Outdated Show resolved Hide resolved
AdyenComponents/UPI/UPIComponent.swift Show resolved Hide resolved
@neelSharma12 neelSharma12 marked this pull request as ready for review May 31, 2024 07:55
@neelSharma12 neelSharma12 merged commit ee8f0c1 into UPI_intent_base May 31, 2024
4 of 8 checks passed
@neelSharma12 neelSharma12 deleted the Build_payByUPIApp_UI branch May 31, 2024 08:02
descorp
descorp reviewed May 31, 2024
View reviewed changes
AdyenComponents/UPI/UPIComponent.swift
Comment on lines +130 to +131
/// The UPI app list item.
internal lazy var upiAppsList: [SelectableFormItem] = {
Copy link
Contributor

@descorp descorp May 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment is not needed if your variable has a descriptive name.

Suggested change
/// The UPI app list item.
internal lazy var upiAppsList: [SelectableFormItem] = {
internal lazy var upiAppsSelectableFormItem: [SelectableFormItem] = {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmamont atmamont atmamont left review comments

@erenbesel erenbesel erenbesel left review comments

@goergisn goergisn goergisn left review comments

@descorp descorp descorp left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
new a pull request that adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neelSharma12 @descorp @goergisn @erenbesel @atmamont