Add null check to isManualCaptureEnabled method of AdminController #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minController. The variable is required for backwards compatibility with PHP 7.
|
SushmitaThakur
approved these changes
Apr 24, 2024
candemiralp
approved these changes
May 2, 2024
candemiralp
approved these changes
May 2, 2024
|
Hello @SpiGAndromeda, Thank you for your contribution. This PR has been merged. Best regards, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The additional null check allows the method to return early of no Adyen transaction was found instead of relying that an exception is thrown. Because the original intend of the try-catch was to catch any exception, the catch clause is changed to catch all Throwables (possible since PHP 7).
I removed the variable from the catch clause in the first place. But because this plugin has to be compatible with Shopware 6.4, it has to be PHP 7.4 compatible. Catch clauses without variable are allowed since PHP 8.
Tested scenarios
None
Fixed issue: #479