-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use babel to transpile typescript, remove global polyfill and add modern bundle #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +204 kB (+39%) 🚨 Total Size: 724 kB
|
* Fixing e2e tests that were failing after changes to attributes on iframes in securedFields release 3.5.4 * Adding missing closing bracket to selectors * removing log
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.3. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.1...1.5.3) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
* fix: e2e for v5 * fix: binLookup error tests * fix: custom card errors * fix: removing unused import
* feat: initial draft with issuers on top * feat: predefined issuers connected to main flow * feat: added tests + cleanup * feat: added e2e test case * feat: preventing ui to show invalid predefined issuers + ui adjustments * feat: clean up useless changes * fix: e2e files scanner * feat: simplified config * feat: translations * feat: including highlighted issuers in the dropdown * fix: i18n * fix: adjusted margin
* Enhance the object stored in state.errors, for a particular securedField, with the properties that we used to send to the onError handler * Fixed error handling for securedFields (custom card) playground * Fixed material design example for securedFields (custom card) playground * Removed unused import in securedFields playground file
* feat: e2e test for sessions * fix: merged master and fixed conflict
…Checkout Sessions
m1aw
requested review from
marcperez,
pabloai,
ribeiroguilherme,
shernaz and
sponglord
as code owners
November 4, 2021 15:02
m1aw
changed the title
Feat/babel runtime
Use babel to transpile typescript, remove global polyfill and add modern bundle
Nov 17, 2021
marcperez
reviewed
Nov 22, 2021
marcperez
reviewed
Nov 22, 2021
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
marcperez
approved these changes
Dec 13, 2021
Merged
I'm using nextjs to build adyen, but webpack chunks is unusually large. Is it wrong for me to use it?
Here is my code::
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ticket has 3 main objectives:
To achieve this we start using core-js-pure via babel-runtime, this explains why babel was introduced.
For fast babel transpilation we started using babel-typescript-preset instead of doing 2 stages (tsc then babel).
For the "modern" build we use babel and babel-preset env with
target:"module"
andbugfixes:true
.Also the umd build now only runs when building the production bundle and not in dev to speed up compilation.
Tested scenarios
Fixed issue:
Might help #337