[wip]Use expiresAt for QR payments #2520
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longyulongyu
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
🦋 Changeset detectedLatest commit: 957d507 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +875 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
longyulongyu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the following QR based payments -
bcmc_mobile,duitnow,payme,paynow,pix,promptpay,swishandwechatpayQR, we improved how we calculate the countdown time.Specifically, we calculate the QR countdown time based on the
expiresAttimestamp from the/paymentsresponse if it is returned in the action object, otherwise we use merchant's frontend configuration.If both are not presented, we fall back to the default value.
Tested scenarios
Added tests and all unit tests passed.
Tested on my device with different timezones, the wechat QR pay shows a 30mins count down (taking the value from
expiresAt)Internal ticket: COWEB-1258