Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to Pay - Adding Visa timeout logging #2797

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

ribeiroguilherme
Copy link
Contributor

@ribeiroguilherme ribeiroguilherme commented Aug 19, 2024

Summary

In this PR, we start reporting to Visa SDK when a timeout related to their SDK happens.

  • We leverage the buildClientProfile function which is triggered once a timeout related to the Visa SDK is thrown.
  • The correlationId is not available during the initialization of the library. If it is still undefined during the timeout part, we pass the srciDpaId to the function (That aims to help Visa to troubleshoot the logs)
  • The executeWithTimeout mechanism was updated to clear the timeout once the Promise is resolved/rejected
  • The TimeoutError object contains the same error message, but it contains new property fields added to it:
    • correlationId: Populated only by Visa timeouts in case the correlationId is available
    • isTimeoutTriggeredBySchemeSdk: Flag indicating if the timeout was triggered by the scheme SDK or by our internal 5 seconds timeout mechanism
    • scheme: scheme that triggered the timeout
    • source: method that triggered the timeout

Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 575c919

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Size Change: +630 B (+0.05%)

Total Size: 1.17 MB

Filename Size Change
packages/lib/dist/adyen.js 309 kB +142 B (+0.05%)
packages/lib/dist/cjs/index.js 270 kB +141 B (+0.05%)
packages/lib/dist/es.modern/index.js 129 kB +190 B (+0.15%)
packages/lib/dist/es/index.js 150 kB +157 B (+0.11%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 7.17 kB
packages/lib/dist/es.modern/cs-CZ.js 6.32 kB
packages/lib/dist/es.modern/da-DK.js 5.72 kB
packages/lib/dist/es.modern/de-DE.js 6.22 kB
packages/lib/dist/es.modern/el-GR.js 8.12 kB
packages/lib/dist/es.modern/es-ES.js 5.87 kB
packages/lib/dist/es.modern/fi-FI.js 5.85 kB
packages/lib/dist/es.modern/fr-FR.js 6.07 kB
packages/lib/dist/es.modern/hr-HR.js 6.14 kB
packages/lib/dist/es.modern/hu-HU.js 6.39 kB
packages/lib/dist/es.modern/it-IT.js 5.92 kB
packages/lib/dist/es.modern/ja-JP.js 6.88 kB
packages/lib/dist/es.modern/ko-KR.js 6.5 kB
packages/lib/dist/es.modern/nl-NL.js 5.87 kB
packages/lib/dist/es.modern/no-NO.js 5.73 kB
packages/lib/dist/es.modern/pl-PL.js 6.38 kB
packages/lib/dist/es.modern/pt-BR.js 5.91 kB
packages/lib/dist/es.modern/pt-PT.js 6.04 kB
packages/lib/dist/es.modern/ro-RO.js 6.17 kB
packages/lib/dist/es.modern/ru-RU.js 7.58 kB
packages/lib/dist/es.modern/sk-SK.js 6.5 kB
packages/lib/dist/es.modern/sl-SI.js 6.03 kB
packages/lib/dist/es.modern/sv-SE.js 5.7 kB
packages/lib/dist/es.modern/zh-CN.js 6.3 kB
packages/lib/dist/es.modern/zh-TW.js 6.42 kB
packages/lib/dist/es/ar.js 7.17 kB
packages/lib/dist/es/cs-CZ.js 6.32 kB
packages/lib/dist/es/da-DK.js 5.72 kB
packages/lib/dist/es/de-DE.js 6.22 kB
packages/lib/dist/es/el-GR.js 8.12 kB
packages/lib/dist/es/es-ES.js 5.87 kB
packages/lib/dist/es/fi-FI.js 5.85 kB
packages/lib/dist/es/fr-FR.js 6.07 kB
packages/lib/dist/es/hr-HR.js 6.14 kB
packages/lib/dist/es/hu-HU.js 6.39 kB
packages/lib/dist/es/it-IT.js 5.92 kB
packages/lib/dist/es/ja-JP.js 6.88 kB
packages/lib/dist/es/ko-KR.js 6.5 kB
packages/lib/dist/es/nl-NL.js 5.87 kB
packages/lib/dist/es/no-NO.js 5.73 kB
packages/lib/dist/es/pl-PL.js 6.38 kB
packages/lib/dist/es/pt-BR.js 5.91 kB
packages/lib/dist/es/pt-PT.js 6.04 kB
packages/lib/dist/es/ro-RO.js 6.17 kB
packages/lib/dist/es/ru-RU.js 7.58 kB
packages/lib/dist/es/sk-SK.js 6.5 kB
packages/lib/dist/es/sl-SI.js 6.03 kB
packages/lib/dist/es/sv-SE.js 5.7 kB
packages/lib/dist/es/zh-CN.js 6.3 kB
packages/lib/dist/es/zh-TW.js 6.42 kB

compressed-size-action

@ribeiroguilherme ribeiroguilherme marked this pull request as ready for review September 10, 2024 13:57
@ribeiroguilherme ribeiroguilherme changed the title [WIP] Click to Pay - Adding Visa timeout logging Click to Pay - Adding Visa timeout logging Sep 10, 2024
Copy link

sonarcloud bot commented Sep 19, 2024

@ribeiroguilherme ribeiroguilherme merged commit c265abc into v5 Sep 23, 2024
12 checks passed
@ribeiroguilherme ribeiroguilherme deleted the feature-add-visa-timeout-logging branch September 23, 2024 09:54
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants