-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click to Pay - Adding Visa timeout logging #2797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 575c919 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +630 B (+0.05%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
ribeiroguilherme
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
September 10, 2024 13:57
ribeiroguilherme
changed the title
[WIP] Click to Pay - Adding Visa timeout logging
Click to Pay - Adding Visa timeout logging
Sep 10, 2024
Quality Gate passedIssues Measures |
sponglord
approved these changes
Sep 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we start reporting to Visa SDK when a timeout related to their SDK happens.
buildClientProfile
function which is triggered once a timeout related to the Visa SDK is thrown.correlationId
is not available during the initialization of the library. If it is still undefined during the timeout part, we pass thesrciDpaId
to the function (That aims to help Visa to troubleshoot the logs)executeWithTimeout
mechanism was updated to clear the timeout once the Promise is resolved/rejectedTimeoutError
object contains the same error message, but it contains new property fields added to it:correlationId
: Populated only by Visa timeouts in case the correlationId is availableisTimeoutTriggeredBySchemeSdk
: Flag indicating if the timeout was triggered by the scheme SDK or by our internal 5 seconds timeout mechanismscheme
: scheme that triggered the timeoutsource
: method that triggered the timeout