Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation on stored cards when billingAddress was required #84

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Fix validation on stored cards when billingAddress was required #84

merged 2 commits into from
Jul 3, 2020

Conversation

marcperez
Copy link
Member

Summary

  • Fix validation on stored cards when billingAddress was required

Tested scenarios

  • Set billingAddressRequired on a stored card, click pay.

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marcperez marcperez merged commit 56c1e28 into master Jul 3, 2020
@marcperez marcperez deleted the fix/billingAddressRequired-storedPaymentMethods branch July 3, 2020 14:32
@marcperez marcperez mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sponglord sponglord sponglord approved these changes

@pabloai pabloai Awaiting requested review from pabloai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcperez @sponglord