Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Introduce summary item in LumeTooltip #113

Merged
merged 1 commit into from
Dec 6, 2022
Merged

✨ Introduce summary item in LumeTooltip #113

merged 1 commit into from
Dec 6, 2022

Conversation

joao-m-santos
Copy link
Contributor

Closes #102

📝 Description

Added an isSummary identifier for TooltipItems
Added a summary option to TooltipOptions
Added a summary prop to LumeTooltip

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

isSummary takes precedence over summary option which takes precedence over summary property.

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos requested a review from a team as a code owner December 2, 2022 09:22
@joao-m-santos joao-m-santos self-assigned this Dec 2, 2022
@joao-m-santos joao-m-santos linked an issue Dec 2, 2022 that may be closed by this pull request
Implement tooltip description slot #112
Closed
@netlify
Copy link

netlify bot commented Dec 2, 2022 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 4d5406d
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/6389c3c84efb010008240257
😎 Deploy Preview https://deploy-preview-113--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joao-m-santos joao-m-santos merged commit cc7027a into main Dec 6, 2022
@joao-m-santos joao-m-santos deleted the 112-implement-tooltip-description-slot branch February 1, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivy27 vivy27 vivy27 approved these changes

Assignees

@joao-m-santos joao-m-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement tooltip description slot ♻️ Take calculating path logic out of the lume-line component
2 participants
@joao-m-santos @vivy27