Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Add other colors (green, orange, red) #136

Merged
merged 1 commit into from
Jan 18, 2023
Merged

💄 Add other colors (green, orange, red) #136

merged 1 commit into from
Jan 18, 2023

Conversation

joao-m-santos
Copy link
Contributor

Relates to #135

📝 Description

Updated values for green, orange and red colors;
Included these generic colors as valid colors for datasets.

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos requested a review from a team as a code owner January 17, 2023 10:53
@joao-m-santos joao-m-santos self-assigned this Jan 17, 2023
@joao-m-santos joao-m-santos linked an issue Jan 17, 2023 that may be closed by this pull request
Add generic colours #135
Closed
@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 07580d5
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/63c6a8931847d000092ab278
😎 Deploy Preview https://deploy-preview-136--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joao-m-santos joao-m-santos merged commit 6b68557 into main Jan 18, 2023
@joao-m-santos joao-m-santos mentioned this pull request Jan 18, 2023
Merged
@joao-m-santos joao-m-santos deleted the 135-add-generic-colours branch February 1, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucas1981 Lucas1981 Lucas1981 approved these changes

@govind-srinidhi govind-srinidhi govind-srinidhi approved these changes

Assignees

@joao-m-santos joao-m-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add generic colours
3 participants
@joao-m-santos @govind-srinidhi @Lucas1981