🐛 Fix repeated label scaleBand issue #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Band scales now use index array as domain and save the labels as a property * Labels are then used for showing the axis label text, while all the mapping is done with the index array
5 tasks
✅ Deploy Preview for adyen-lume ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
govind-srinidhi
previously approved these changes
Feb 1, 2023
govind-srinidhi
approved these changes
Feb 1, 2023
joao-m-santos
deleted the
145-scaleband-error-when-labels-are-repeated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
📝 Description
💥 Is this a breaking change (Yes/No):
📝 Additional Information
Before submitting the PR, please make sure you do the following
fixes #123).