-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 invert bar chart options upon orientation change #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivy27
changed the title
📝 update storybook templates
📝 add storybook template for bar chart
Oct 24, 2022
vivy27
force-pushed
the
invert-bar-chart-options-upon-orientation-change
branch
from
October 24, 2022 15:42
1017c52
to
eadaf14
Compare
vivy27
changed the title
📝 add storybook template for bar chart
📝 invert bar chart options upon orientation change
Oct 24, 2022
vivy27
force-pushed
the
invert-bar-chart-options-upon-orientation-change
branch
from
October 25, 2022 09:41
eadaf14
to
446ae78
Compare
Lucas1981
previously approved these changes
Oct 25, 2022
vivy27
force-pushed
the
invert-bar-chart-options-upon-orientation-change
branch
2 times, most recently
from
October 25, 2022 10:53
8eee265
to
549e101
Compare
Lucas1981
previously approved these changes
Oct 25, 2022
joao-m-santos
requested changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vivy27
force-pushed
the
invert-bar-chart-options-upon-orientation-change
branch
from
October 26, 2022 07:16
8337a68
to
35a0b1e
Compare
vivy27
force-pushed
the
invert-bar-chart-options-upon-orientation-change
branch
2 times, most recently
from
October 28, 2022 09:45
0579b7e
to
80b9c3f
Compare
govind-srinidhi
previously approved these changes
Oct 28, 2022
vivy27
force-pushed
the
invert-bar-chart-options-upon-orientation-change
branch
from
October 28, 2022 12:15
80b9c3f
to
db928c5
Compare
vivy27
force-pushed
the
invert-bar-chart-options-upon-orientation-change
branch
2 times, most recently
from
November 4, 2022 12:13
c7023be
to
70d6a61
Compare
vivy27
force-pushed
the
invert-bar-chart-options-upon-orientation-change
branch
from
November 4, 2022 12:18
70d6a61
to
cb7edd2
Compare
joao-m-santos
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #
📝 Description
Adding new template for bar charts which inverts the options when orientation changes. Therefore, preventing the
NaN
orundefined
error in the UI.💥 Is this a breaking change (Yes/No):
📝 Additional Information
Before submitting the PR, please make sure you do the following
fixes #123
).