Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 invert bar chart options upon orientation change #29

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

vivy27
Copy link
Contributor

@vivy27 vivy27 commented Oct 24, 2022

Relates to #

📝 Description

Adding new template for bar charts which inverts the options when orientation changes. Therefore, preventing the NaN or undefined error in the UI.

Add a brief description

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@vivy27 vivy27 requested a review from a team as a code owner October 24, 2022 15:41
@vivy27 vivy27 changed the title 📝 update storybook templates 📝 add storybook template for bar chart Oct 24, 2022
@vivy27 vivy27 force-pushed the invert-bar-chart-options-upon-orientation-change branch from 1017c52 to eadaf14 Compare October 24, 2022 15:42
@vivy27 vivy27 changed the title 📝 add storybook template for bar chart 📝 invert bar chart options upon orientation change Oct 24, 2022
@vivy27 vivy27 self-assigned this Oct 25, 2022
@vivy27 vivy27 force-pushed the invert-bar-chart-options-upon-orientation-change branch from eadaf14 to 446ae78 Compare October 25, 2022 09:41
Lucas1981
Lucas1981 previously approved these changes Oct 25, 2022
@vivy27 vivy27 force-pushed the invert-bar-chart-options-upon-orientation-change branch 2 times, most recently from 8eee265 to 549e101 Compare October 25, 2022 10:53
@vivy27 vivy27 requested a review from Lucas1981 October 25, 2022 10:53
Lucas1981
Lucas1981 previously approved these changes Oct 25, 2022
Copy link
Contributor

@joao-m-santos joao-m-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes, the options control becomes unusable. Could you try to find a way that will still enable users to add/remove options?

Also found this:
image

@vivy27
Copy link
Contributor Author

vivy27 commented Oct 26, 2022

With these changes, the options control becomes unusable. Could you try to find a way that will still enable users to add/remove options?

Also found this: image

Correct. I've added the updateArgs method. Now options in control panel is usable.

@vivy27 vivy27 force-pushed the invert-bar-chart-options-upon-orientation-change branch 2 times, most recently from 0579b7e to 80b9c3f Compare October 28, 2022 09:45
@vivy27 vivy27 force-pushed the invert-bar-chart-options-upon-orientation-change branch from 80b9c3f to db928c5 Compare October 28, 2022 12:15
@vivy27 vivy27 force-pushed the invert-bar-chart-options-upon-orientation-change branch 2 times, most recently from c7023be to 70d6a61 Compare November 4, 2022 12:13
@vivy27 vivy27 force-pushed the invert-bar-chart-options-upon-orientation-change branch from 70d6a61 to cb7edd2 Compare November 4, 2022 12:18
@vivy27 vivy27 merged commit 6eac173 into main Nov 4, 2022
@vivy27 vivy27 deleted the invert-bar-chart-options-upon-orientation-change branch November 4, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants