Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

39 Allow for custom tooltip targetElement #44

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

joao-m-santos
Copy link
Contributor

Closes to #39

📝 Description

Added support for targetElement option inside tooltipOptions

  • If undefined, it will generate tooltip anchors and attach to them (default);
  • If "self", it will attach to the <svg> container element;
  • If provided with an Element, it will attach to it.

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Oct 27, 2022
@joao-m-santos joao-m-santos requested a review from a team as a code owner October 27, 2022 13:59
@joao-m-santos joao-m-santos changed the title ✨ Add option to set tooltip targetElement 39 Allow for custom tooltip targetElement Oct 27, 2022
@joao-m-santos joao-m-santos force-pushed the 39-allow-for-custom-tooltip-targetelement branch from 6ba5887 to 8af1cd0 Compare October 28, 2022 07:28
vivy27
vivy27 previously approved these changes Oct 28, 2022
@vivy27 vivy27 force-pushed the 39-allow-for-custom-tooltip-targetelement branch from 8af1cd0 to 6c0c079 Compare October 28, 2022 09:52
@joao-m-santos joao-m-santos merged commit c8f6953 into main Oct 28, 2022
@joao-m-santos joao-m-santos deleted the 39-allow-for-custom-tooltip-targetelement branch February 1, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants