Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Updated the storybook mock data #66

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Conversation

govind-srinidhi
Copy link
Contributor

@govind-srinidhi govind-srinidhi commented Nov 10, 2022

Relates to Replace all mock data in Storybook to unbranded data#65

📝 Description

Storybook mock data has information about some brand names, overrding them with some pets :)

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@govind-srinidhi govind-srinidhi requested a review from a team as a code owner November 10, 2022 14:55
@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 61cf26a
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/636d137facac9b0009b4dbd0
😎 Deploy Preview https://deploy-preview-66--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@govind-srinidhi govind-srinidhi changed the title 📝 Updated the storybook mock data so that we do not show information … 📝 Updated the storybook mock data Nov 10, 2022
@joao-m-santos
Copy link
Contributor

Should be referencing the issue # in the PR description!

@govind-srinidhi
Copy link
Contributor Author

Added the ticket reference in the PR description :)

@govind-srinidhi govind-srinidhi merged commit 764f63d into main Nov 10, 2022
@joao-m-santos joao-m-santos deleted the storybook-mock-data branch February 1, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants