Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Improve axis tick display on hover #68

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

joao-m-santos
Copy link
Contributor

Relates to #62

📝 Description

Made it so that the label of which index is being hovered clearly pop up above all other axis labels.

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Adds the portal-vue dependency!

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Nov 11, 2022
@netlify
Copy link

netlify bot commented Nov 11, 2022

Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 7fb4f53
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/63777d2208e04f00092259b0
😎 Deploy Preview https://deploy-preview-68--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joao-m-santos joao-m-santos force-pushed the 62-improve-skipped-axis-label-display-on-hover branch from 44f7f44 to 7fb4f53 Compare November 18, 2022 12:40
@joao-m-santos joao-m-santos marked this pull request as ready for review November 18, 2022 12:41
@joao-m-santos joao-m-santos requested a review from a team as a code owner November 18, 2022 12:41
@joao-m-santos joao-m-santos merged commit bf6d5b6 into main Nov 21, 2022
@joao-m-santos joao-m-santos deleted the 62-improve-skipped-axis-label-display-on-hover branch February 1, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants