♻️ Use portal to broker for the chart legend in the lume chart compo… #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for adyen-lume ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @click="$emit('click', $event)" | ||
| <vue-portal-target | ||
| name="legend-bottom" | ||
| class="lume-chart__legend--bottom u-display-flex u-width-full" |
There was a problem hiding this comment.
No need for helper classes here, lume-chart__legend--bottom already places it correctly
Lucas1981
force-pushed
the
96-use-portal-to-broker-for-the-chart-legend-in-the-lume-chart-component
branch
from
3ed639f
to
862a260
Compare
…ar chart for bottom portal
joao-m-santos
approved these changes
Nov 22, 2022
joao-m-santos
approved these changes
Nov 24, 2022
joao-m-santos
deleted the
96-use-portal-to-broker-for-the-chart-legend-in-the-lume-chart-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nent #96
Relates to #
📝 Description
💥 Is this a breaking change (Yes/No):
📝 Additional Information
Before submitting the PR, please make sure you do the following
fixes #123).