Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add option to control line width #98

Conversation

joao-m-santos
Copy link
Contributor

Relates to #95

πŸ“ Description

Added an option lineWidth to customize line width
Added that to a new interface LineChartOptions
lume-line-group now also scales its lume-points to the lines' width

πŸ’₯ Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

πŸ“ Additional Information

Removed some unused SASS variables

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos requested a review from a team as a code owner November 22, 2022 13:16
@joao-m-santos joao-m-santos self-assigned this Nov 22, 2022
@netlify
Copy link

netlify bot commented Nov 22, 2022

βœ… Deploy Preview for adyen-lume ready!

Name Link
πŸ”¨ Latest commit b2c6d29
πŸ” Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/637ce538b6ebff00083006f0
😎 Deploy Preview https://deploy-preview-98--adyen-lume.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joao-m-santos joao-m-santos merged commit 3bc3ae6 into main Nov 22, 2022
@joao-m-santos joao-m-santos linked an issue Nov 24, 2022 that may be closed by this pull request
@joao-m-santos joao-m-santos deleted the 95-provide-option-to-customize-line-chartsparkline-line-width branch February 1, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option to customize line chart/sparkline line width
3 participants