Migrating to Hugo #13
Conversation
Merge remote-tracking branch 'hugo/master' into switch2hugo merge inky's fork: Aeg-dev/AegSite-hugo@a09bb1b original theme: https://github.com/h-enk/doks
re ``` \[\[img/([^ \.]+)\.(png|jpg)\]\]  ```
```re \[\[([^\[\]]+)(\s+)?\n(\s+)? [[$1 ```
```re
\[\[([^\|:\.#/\[\]]+)\]\]
[$1]({{< relref "$1" >}})
```
+ "Typesetting_Tutorial" => "Visual_Typesetting" + replace space in links + remove empty link
```re
\[\[(.[^`\\]+)\|([^ ]+)\]\]
[$1]({{< relref "$2" >}})
```
Makdown was formatted with mdformat https://github.com/executablebooks/mdformat In addition the following plugins were used: mdformat-frontmatter mdformat-tables mdformat-deflist
A build of the site before and after 5770dfe was compared with diff. All resulting unwanted differences were undone. Some additional changes were also made: - Added plaintext as language on ass code blocks - Fixed nested Description List - Removed bolding from description list heading (as it's done in css) - Minor formatting fixes along the way
|
@inkydragon any chance you can take a look at @seproDev's work? If not, I'll spin up a new branch and review it all as a whole. |
|
@CoffeeFlux I'll take a look this weekend. A quick check looks good. |
Windows file/folder names can not end in dots, but hugo doesn't take this in to account.
Finish migration to hugo
|
@CoffeeFlux Ready for review. |
|
Thanks for your efforts inkydragon and seproDev!
|
|
Thank you for taking a look at the site. I have addressed your comments (other than the license one) in this branch. This could be merged in to the |
| - name: Deploy to GitHub Pages | ||
| uses: peaceiris/actions-gh-pages@v3 |
There was a problem hiding this comment.
I guess I'll need to go replace this with something that deploys to the main site? I can probably deploy to aegisub.github.io as well automatically.
There was a problem hiding this comment.
Maybe Github page + custom domain?
| @@ -0,0 +1,2 @@ | |||
| baseurl: 'https://aegisub.github.io/aegisite/' | |||
There was a problem hiding this comment.
Does this need to be changed if I want to primary deploy target to be aegisub.org?
There was a problem hiding this comment.
We can probably just turn canonifyURLs off and remove the baseurl.
This seemes to be the old default from doks which has since been changed.
There was a problem hiding this comment.
But if you want to deploy this site to github pages, you should set baseurl. Otherwise, baseurl will be https://aegisub.github.io, which lead all links to be 404.
There was a problem hiding this comment.
Right Github Pages will only host on https://<organization>.github.io if the repo is named <organization>.github.io, otherwise it will host on https://<organization>.github.io/<repo-name>.
I talked with CoffeeFlux on Discord and he wants to host the aegisub.org site on his own server instead of Github infrastructure, but would be fine with having Github Pages up as a backup.
I guess we could add two build enviroments with seperate config files and npm run scripts (--environment github) to deploy both to Github Pages with canonicalized URLs and to CoffeeFlux' server without.
The alternative would be dropping Github Pages entirely.
There was a problem hiding this comment.
The advantage of hosting via Github Pages is that it can be managed from the repository alone, including automatic builds on new commits to master and it's generally very resilient since the hosting is external. I don't see a particular reason for not using Github Pages as the primary website if it's already half-supported.
https://aeg-dev.github.io/AegiSite/
TODO
{::template) in docsdownloads/changelog/,docs/3.2/commands/xref: #11