Track item attributes and visibility #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding aeneas PR: AeneasVerif/aeneas#116 |
Nadrieril
changed the title
R1kM
reviewed
Apr 11, 2024
Closed
sonmarcho
requested changes
Apr 16, 2024
sonmarcho
requested changes
Apr 17, 2024
sonmarcho
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63. Fixes #69. Fixes #68.
I made
attributesbe a list of strings for now, we can have something more structured if needed later. I madepublica boolean, we can gather something more precise if needed. Note the comment about pub-in-priv; whether that's ok or not depends on what we need the info for.