Merge Predicates into GenericParams
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
commented
Jun 21, 2024
Nadrieril
commented
Jun 21, 2024
Nadrieril
commented
Jun 21, 2024
|
The aeneas and eurydice PRs are ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges two structs together. This reduces code duplication, as these two always came together in the AST. This is correct to do because predicates can appear exactly in the same places that clauses can, so it makes sense to group them together. This is part of my attempts to clarify how we deal with generics in preparation of #127 and #67 among others.
I will now prepare the changes to aeneas and eurydice.