Adds Python 3.9 support #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janzill
approved these changes
Aug 2, 2021
| @@ -30,7 +30,7 @@ jobs: | |||
| runs-on: windows-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: [ '3.6', '3.7', '3.8' ] | |||
There was a problem hiding this comment.
@pedrocamargo no 3.9 on windows? Also, spacing is inconsistent
There was a problem hiding this comment.
Testing cannot be done because PyTables is not available for Python 3.9 yet (that's the HDF5 library used by OpenMatrix). In practice people can use by downloading the binaries from Chris Gohlke, but nothing we should put in here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytables (a requirement for OpenMatrix ) is not available for Python 3.9, so we need to change some stuff around to make it work