This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Remove CFBundleExecutable key from AffirmSDK.bundle/Info.plist #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue outlined in https://stackoverflow.com/questions/32096130
|
------------------------------------------------------------------------------------------------------------
Type your response on top of this email to respond to this case. Learn Email Commands Here - https://support.desk.com/customer/portal/articles/1191712-reply-via-email-commands
------------------------------------------------------------------------------------------------------------
Case Assignment Notification - Case #37740 ( https://affirm.desk.com/web/agent/case/37740 )
Affirm | Nov 29, 2017 04:20AM UTC
------------------------------------------------------------------------------------------------------------
Case #37740
Customer: Affirm/affirm-ios-sdk
Subject: [Affirm/affirm-ios-sdk] Remove CFBundleExecutable key from AffirmSDK.bundle/Info.plist (#8)
------------------------------------------------------------------------------------------------------------
Case Information (37740):
Subject: [Affirm/affirm-ios-sdk] Remove CFBundleExecutable key from AffirmSDK.bundle/Info.plist (#8)
Description:
Status: Open
Priority: 4
Assigned Group: MTS
------------------------------------------------------------------------------------------------------------
Case History
------------------------------------------------------------------------------------------------------------
goatmad at NOV 29, 2017 | 08:20PM PST:
When archiving with a Release scheme, the build succeeded. However, when uploading it to iTunes Connect, we received the following error:
[Transporter Error Output]: ERROR ITMS-90535: "Unexpected CFBundleExecutable Key. The bundle at 'Payload/StockX.app/Frameworks/AffirmSDK.framework/AffirmSDK.bundle' does not contain a bundle executable. If this bundle intentionally does not contain an executable, consider removing the CFBundleExecutable key from its Info.plist and using a CFBundlePackageType of BNDL. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue."
I did some Googling and found this SO post that outlines the issue: [https://stackoverflow.com/questions/32096130](https://stackoverflow.com/questions/32096130).
It looks like we can just nix the `CFBundleExecutable` key and call it a day. I believe this is the same issue reported in #5 (unfortunately, the issue was abandoned).
Let me know if you have any questions or concerns!
You can view, comment on, or merge this pull request online at:
#8
…-- Commit Summary --
* remove CFBundleExecutable from AffirmSDK.bundle/Info.plist
-- File Changes --
M AffirmSDK/AffirmSDK.bundle/Info.plist (2)
-- Patch Links --
https://github.com/Affirm/affirm-ios-sdk/pull/8.patch
https://github.com/Affirm/affirm-ios-sdk/pull/8.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#8
------------------------------------------------------------------------------------------------------------
This message was sent to reply@reply.github.com in reference to Case #37740
------------------------------------------------------------------------------------------------------------
|
farhadn
approved these changes
Feb 9, 2018
|
@jeffaburt FYI if you run into this elsewhere: Carthage requires this key so it forces you to make 2 Info.plists |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When archiving with a Release scheme, the build succeeded. However, when uploading it to iTunes Connect, we received the following error:
I did some Googling and found this SO post that outlines the issue: https://stackoverflow.com/questions/32096130.
It looks like we can just nix the
CFBundleExecutablekey and call it a day. I believe this is the same issue reported in #5 (unfortunately, the issue was abandoned).Let me know if you have any questions or concerns!