Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CountryPhoneData: Allow more DK numbers #366

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

MarkusAbtion
Copy link
Contributor

The mobile_begins_with was too restrictive.
So a number starting with eg. 55 wasn't being accepted.

If we want to restrict it to mobile phones over landlines (which I don't see the purpose of), we could add the following beginnings to the array instead:

342, 344-349, 356-357, 359, 362, 365-366, 389, 398, 431, 441, 462, 466, 468, 472, 474, 476, 478, 485-486, 488-489, 493-496, 498-499, 542-543, 545, 551-552, 556, 571-574, 577, 579, 584, 586-587, 589, 597-598, 627, 629, 641, 649, 658, 662-665, 667, 692-694, 697, 771-772, 782-783, 785-786, 788-789, 826-827, 829

@Bossa573
Copy link
Member

Bossa573 commented Oct 2, 2023

Hello,
please provide the docs showing that the new prefixes are mobile phone numbers.

The library is intended for mobile phone number only and will not accept landline formats

@MarkusAbtion
Copy link
Contributor Author

Do you have a version for landlines also?

@MarkusAbtion
Copy link
Contributor Author

@Bossa573
Copy link
Member

Bossa573 commented Oct 2, 2023

We don't have a landline version of this lib

@MarkusAbtion
Copy link
Contributor Author

Ah, just read this:
https://github.com/AfterShip/phone#allowlandline-vs-validatemobileprefix

I'll update this PR to simply add the extra mobile beginnings.

This adds the 3-digit starting codes as well.
@MarkusAbtion
Copy link
Contributor Author

Hi @Bossa573,
Updated the PR with the additional digits

@Bossa573 Bossa573 merged commit 611ca94 into AfterShip:master Oct 2, 2023
1 check passed
@Bossa573
Copy link
Member

Bossa573 commented Oct 2, 2023

thank you for the update, this will be included in the new version after the final verification

Bossa573 added a commit that referenced this pull request Oct 2, 2023
- #366 add Denmark phone number format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants