Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update country_phone_data.ts with ANT #394

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

Harm-Nullix
Copy link
Contributor

@Harm-Nullix
Copy link
Contributor Author

@Bossa573
Copy link
Member

Bossa573 commented Jul 5, 2024

it seems that the rule is mixed with non-mobile phone number format according to the wiki, can you remove all those? (non-mobile phone number format won't be included)

@Harm-Nullix
Copy link
Contributor Author

I think I fixed the numbers.
I know for a fact that +599 416 xxxx is al valid mobile phone number. So the wiki does show it for bonaire and curacao, but these hints are not respresentable for saba and sint eustatius

@Bossa573 Bossa573 merged commit 3e4e900 into AfterShip:master Jul 5, 2024
@Bossa573
Copy link
Member

Bossa573 commented Jul 5, 2024

i think the format should good to go, thank you for the PR

@Harm-Nullix
Copy link
Contributor Author

Thanks for the quick reaction!

Is it expected to have this in a version soon, or do you do releases periodically?

@Bossa573
Copy link
Member

Bossa573 commented Jul 5, 2024

I reverified the wiki and am thinking of stopping using Netherlands Antilles and separating it into
Curaçao (country code CW / CUW) and Caribbean Netherlands (country code BQ / BES), like this:


[
	...
	{
		alpha2: 'CW',
		alpha3: 'CUW',
		country_code: '599',
		country_name: 'Curaçao',
		mobile_begin_with: ['95', '96'],
		phone_number_lengths: [8]
	},
	...
	
	{
		alpha2: "BQ", 
		alpha3: "BES", 
		country_code: "599", 
		country_name: "Caribbean Netherlands", 
		mobile_begin_with: ['3', '416', '700', '701','795'], 
		phone_number_lengths: [7, 8]
	},

	...
]

what is your take @Harm-Nullix ?

@Harm-Nullix
Copy link
Contributor Author

Yes, that look awesome, in that case you could remove phone length 8 from BES

@Bossa573
Copy link
Member

Bossa573 commented Jul 5, 2024

ok, I'll go for that way then

Bossa573 added a commit that referenced this pull request Jul 5, 2024
Bossa573 added a commit that referenced this pull request Jul 5, 2024
- #394 ANT phone number format
@Harm-Nullix
Copy link
Contributor Author

I also saw in the code that Aruba is very broadly defined, it is defined with mobile_begin_with: ['5', '6', '7', '9'],
Where in fact the numbers are ['56', '59', '64', '73', '74', '99'].

I did not want to touch to much because it was not part of the focus, but since you are splitting those two, might want to revise Aruba as well

For ref: https://en.wikipedia.org/wiki/Telephone_numbers_in_Aruba

@Bossa573
Copy link
Member

Bossa573 commented Jul 5, 2024

https://github.com/AfterShip/phone/releases/tag/3.1.47
https://www.npmjs.com/package/phone/v/3.1.47?activeTab=versions

it's up now

@Bossa573
Copy link
Member

Bossa573 commented Jul 5, 2024

oh didn't see the aruba one, that one might be handled separatedly

Bossa573 added a commit that referenced this pull request Jul 5, 2024
Bossa573 added a commit that referenced this pull request Jul 5, 2024
- #394 Aruba phone number format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants