-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update country_phone_data.ts with ANT #394
Conversation
it seems that the rule is mixed with non-mobile phone number format according to the wiki, can you remove all those? (non-mobile phone number format won't be included) |
I think I fixed the numbers. |
i think the format should good to go, thank you for the PR |
Thanks for the quick reaction! Is it expected to have this in a version soon, or do you do releases periodically? |
I reverified the wiki and am thinking of stopping using Netherlands Antilles and separating it into
what is your take @Harm-Nullix ? |
Yes, that look awesome, in that case you could remove phone length 8 from BES |
ok, I'll go for that way then |
- #394 ANT phone number format
I also saw in the code that Aruba is very broadly defined, it is defined with I did not want to touch to much because it was not part of the focus, but since you are splitting those two, might want to revise Aruba as well For ref: https://en.wikipedia.org/wiki/Telephone_numbers_in_Aruba |
oh didn't see the aruba one, that one might be handled separatedly |
- #394 Aruba phone number format
#392